@hdevalence

I had to remove the redundant imports since cargo +nightly check complained. Specifically, Vec is in the prelude and is redundant to import.

@autquis ah yes see also this PR: arkworks-rs/algebra#790 to tackle the same sort of issues in algebra

Edit: I actually wonder why this works, given that similar changes in poly commit failed no-std

@mmagician I didn't understand what I should fix in arkworks-rs/algebra#790? As it is merged already.

Why it works: I guess because it is not completely no-default-features and r1cs is enabled. This is the command for no_std check:

cargo build --no-default-features --features=r1cs --target aarch64-unknown-none

What I meant is that the algebra PR addressed similar issues.

A gentle ping :)

Also @mmaker since I'm tagging you in a few places now, maybe you could also take a peek at this?

CI failure is due to this change probably rust-lang/rust#121752
@Cesar199999 @Antonio95

@autquis Yes sorry, I had to update the branch, I'll fix it

Took a quick peek! The PR looks okay, but there isn't much to say. I'd personally encourage your to add a few lines of documentation so that people are well-aware of the limitations of this trait, especially concerning the statement serialization (the user is on their own) and the bit vs bytes part.

That said, I'm happy to see that people are starting to need something that works both over bytes and algebraic sponges :)